Cleanup adapters code and add javascript adapter #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the adapters code, the code for installing/fetching a binary is now in 2 separate methods for the Separation of Concerns. It's also more streamlined how the adapter should be implemented.
This PR also adds the JavaScript debug adapter, which I will work on right after this PR.
cc @Anthony-Eid
To tests JavaScript debugging, you need to have the following task:
Note:
Debugging JavaScript only works if you pass in a program, I will work on making the other reverse requests work, so we can support more ways how you can debug JavaScript.