Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup adapters code and add javascript adapter #48

Merged
merged 8 commits into from
Oct 9, 2024

Conversation

RemcoSmitsDev
Copy link
Owner

@RemcoSmitsDev RemcoSmitsDev commented Oct 9, 2024

This PR cleans up the adapters code, the code for installing/fetching a binary is now in 2 separate methods for the Separation of Concerns. It's also more streamlined how the adapter should be implemented.

This PR also adds the JavaScript debug adapter, which I will work on right after this PR.

cc @Anthony-Eid

To tests JavaScript debugging, you need to have the following task:

{
	"label": "Javascript Debug file",
	"command": "Javascript Debug file",
	"task_type": {
		"type": "debug",
		"kind": "javascript",
		"program": "/Users/remcosmits/Documents/code/prettier-test/test.js",
		"request": "launch",
		"initialize_args": {
			"cwd": "/Users/remcosmits/Documents/code/prettier-test" // This is required for now, later the adapter will insert this.
		}
	}
}

Note:
Debugging JavaScript only works if you pass in a program, I will work on making the other reverse requests work, so we can support more ways how you can debug JavaScript.

@RemcoSmitsDev RemcoSmitsDev marked this pull request as ready for review October 9, 2024 13:45
@RemcoSmitsDev RemcoSmitsDev merged commit 7e2c138 into debugger Oct 9, 2024
0 of 4 checks passed
@RemcoSmitsDev RemcoSmitsDev deleted the cleanup-adapters branch October 9, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant