Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Money type deserialization #55

Merged
merged 7 commits into from
Nov 18, 2017
Merged

Fix Money type deserialization #55

merged 7 commits into from
Nov 18, 2017

Commits on Nov 14, 2017

  1. Added tests to show failing deserialization scenarios

    @oskardudycz
    oskardudycz committed Nov 14, 2017
    Configuration menu
    Copy the full SHA
    c8e30e7 View commit details
    Browse the repository at this point in the history

  2. Added fixes for failing scenarios

    @oskardudycz
    oskardudycz committed Nov 14, 2017
    Configuration menu
    Copy the full SHA
    4b0b3f1 View commit details
    Browse the repository at this point in the history

  3. Updated condition to use currencyProperty instead length

    @oskardudycz
    oskardudycz authored Nov 14, 2017
    Configuration menu
    Copy the full SHA
    b7c2613 View commit details
    Browse the repository at this point in the history

  4. Small formatting change to follow if brackets convention

    @oskardudycz
    oskardudycz authored Nov 14, 2017
    Configuration menu
    Copy the full SHA
    5e56a08 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2017

  1. Brought back requirement for json to have both amount and currency. 

    Updated finding json parameters from FirstOrDefault to SingleOrDefault.
Added tests for negative deserialization scenarios.
    @oskardudycz
    oskardudycz committed Nov 18, 2017
    Configuration menu
    Copy the full SHA
    69c4ca4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/oskardudycz/NodaMoney 

    # Conflicts:
#	src/NodaMoney.Serialization.AspNet/MoneyJavaScriptConverter.cs
#	src/NodaMoney/Serialization/JsonNet/MoneyJsonConverter.cs
    @oskardudycz
    oskardudycz committed Nov 18, 2017
    Configuration menu
    Copy the full SHA
    9690246 View commit details
    Browse the repository at this point in the history

  3. Empty commit to retrigger build

    @oskardudycz
    oskardudycz committed Nov 18, 2017
    Configuration menu
    Copy the full SHA
    270c721 View commit details
    Browse the repository at this point in the history