feat: replace deprecated Stably USDS with Sky USDS #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The token list contains the old deprecated Stably USDS token (address
0xA4Bdb11dc0a2bEC88d24A3aa1E6Bb17201112eBe) which has been superseded by Sky USDS (address0xdC035D45d973E3EC169d2276DDab16f1e407384F). Additionally, the token list uses IDUSDS-sky-mainnetwhile Request Finance's API usesUSDS-mainnet, creating naming inconsistency.Background on Stably USDS deprecation:
According to Etherscan, "StableUSD has been renamed to Stably USD Classic (USDSC) and is no longer supported by the issuer." The token has been deprecated and Stably is no longer maintaining this stablecoin. For more information, see https://stably.io/usdsc.
Proposed Solution
USDS-sky-mainnettoUSDS-mainnet(reusing the freed ID)This aligns the token list with Request Finance's currency endpoint naming convention.
Considerations
Context:
This change was originally proposed by @pclaesen in #12. At that time, I preserved the old Stably USDS token for backward compatibility concerns. After database verification confirmed zero production usage of the old token (address
0xA4Bdb11dc0a2bEC88d24A3aa1E6Bb17201112eBe), it's now safe to complete the migration that @pclaesen originally intended.Why reusing the ID is safe:
USDS-mainnetfor Sky USDS (not Stably), which implies they also never used the deprecated Stably USDS token0xA4Bdb...vs0xdC035D...), preventing any collisionImpact:
USDS-mainnetID matching Request Finance APICo-authored-by: @pclaesen