fix: next release #1517
fix: next release #1517
Conversation
WalkthroughThe changes in this pull request involve the addition of a new environment variable Changes
Possibly related issues
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
rodrigopavezi
requested review from
MantisClone,
aimensahnoun,
alexandre-abrioux and
sstefdev
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
.circleci/config.yml (2)
9-10: Memory configuration change looks good!The addition of
NODE_OPTIONS='--max-old-space-size=4096'is an appropriate solution for the out-of-memory issues. This configuration will provide 4GB of heap memory for Node.js processes.Consider:
- Adding a comment explaining why this memory increase was necessary
- Monitoring memory usage in CircleCI builds to ensure 4GB is sufficient
Based on the output, I can now generate the final response as we have found concrete evidence of remaining canary configuration.
The
--canaryoption is still present in the package.json scriptsThe PR objectives mention removing the
--canaryoption, but it's still present in the root package.json file under thepublish-prereleasescript:"publish-prerelease": "yarn lerna publish --preid development --skip-git --yes --canary"This script needs to be updated to align with the PR's versioning changes.
🔗 Analysis chain
Line range hint
452-486: Verify the complete implementation of versioning changesThe PR objectives mention removing the
--canaryoption from the CI release script, but this change is not visible in the current diff. Please ensure all necessary changes for fixing the versioning are properly implemented.
The output shows that there's still a
--canaryoption present in thepublish-prereleasescript within a package.json file. Let me verify if this is the only instance and check the PR changes to see if this was meant to be removed.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for any remaining canary-related configurations # Search for canary-related configurations echo "Searching for canary-related configurations..." rg --type yaml --type json "canary|--canary" -l # Check package.json files for version-related scripts echo "Checking package.json files for version-related scripts..." fd package.json --type f --exec jq -r 'select(.scripts != null) | .scripts | to_entries | .[] | select(.value | contains("canary") or contains("version"))' {}Length of output: 568
Script:
#!/bin/bash # Get the specific content of the package.json file echo "Content of package.json with canary option:" rg --type json "canary" -C 5 # Check if this is modified in the PR echo "Checking PR changes related to versioning:" git diff origin/main -- '**/package.json' '.circleci/config.yml'Length of output: 1097
Fixes #1503
Problem
Next release is not working on circle ci and it seems is due to out of memory issues. Furthermore, versioning is broken on npm
Add
NODE_OPTIONS: '--max-old-space-size=4096'to the node image.I have changed the CI release script removing the --canary option so the versions will look like that.
Summary by CodeRabbit