From cab3a63329219b8ad430cd9a5c7f1e235c6b4502 Mon Sep 17 00:00:00 2001 From: Andy Boedo Date: Wed, 24 Jul 2024 18:50:18 -0300 Subject: [PATCH 1/2] re-added the ui tests job --- .circleci/config.yml | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 3c87204fb0..380d7349bd 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -1279,9 +1279,14 @@ workflows: - not: << pipeline.parameters.generate_snapshots >> - not: << pipeline.parameters.generate_revenuecatui_snapshots >> jobs: - - lint - - run-test-ios-17 - - pod-lib-lint + - lint: + name: "swiftlint" + - run-test-ios-17: + name: "Unit tests" + - pod-lib-lint: + name: "Pod lib lint" + - spm-revenuecat-ui-ios-17: + name: "RevenueCatUI tests" create-tag: when: From 9ae62e32cf8c1938195f7499c4f59ea83e8bd865 Mon Sep 17 00:00:00 2001 From: Andy Boedo Date: Thu, 25 Jul 2024 17:59:02 -0300 Subject: [PATCH 2/2] improvements from PR comments --- .circleci/config.yml | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 380d7349bd..a4fa254c11 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -569,7 +569,7 @@ jobs: name: RevenueCatUI API Tests command: bundle exec fastlane build_revenuecatui_api_tester - spm-revenuecat-ui-ios-17: + run-revenuecat-ui-ios-17: <<: *base-job parameters: xcode_version: @@ -1269,7 +1269,7 @@ workflows: jobs: - spm-revenuecat-ui-ios-15 - spm-revenuecat-ui-ios-16 - - spm-revenuecat-ui-ios-17 + - run-revenuecat-ui-ios-17 build-test: when: @@ -1279,14 +1279,10 @@ workflows: - not: << pipeline.parameters.generate_snapshots >> - not: << pipeline.parameters.generate_revenuecatui_snapshots >> jobs: - - lint: - name: "swiftlint" - - run-test-ios-17: - name: "Unit tests" - - pod-lib-lint: - name: "Pod lib lint" - - spm-revenuecat-ui-ios-17: - name: "RevenueCatUI tests" + - lint + - run-test-ios-17 + - pod-lib-lint + - run-revenuecat-ui-ios-17 create-tag: when: @@ -1411,7 +1407,7 @@ workflows: - spm-release-build-xcode-15 - spm-revenuecat-ui-ios-15 - spm-revenuecat-ui-ios-16 - - spm-revenuecat-ui-ios-17 + - run-revenuecat-ui-ios-17 - spm-revenuecat-ui-watchos - installation-tests-cocoapods - installation-tests-swift-package-manager