Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add osxphotos fix --edited-image-type #336

Open
RhetTbull opened this issue Jan 5, 2021 · 0 comments
Open

Add osxphotos fix --edited-image-type #336

RhetTbull opened this issue Jan 5, 2021 · 0 comments
Labels
feature request New feature or request

Comments

@RhetTbull
Copy link
Owner

Not entirely sure I want to go down the rabbit hole of having osxphotos modify anything in Photos but this would likely be a simple feature with low probability of breaking anything.

In response to Issue #322 there are likely other apps that store non-jpeg images as a .jpeg file when editing a photo in external app. Could add a "fix" command to osxphotos that would at first have only one option: --edited-image-type

  1. Find all files with adjustments that are not missing (must be present on disk)
  2. check PhotoInfo.uti and check type of image (using filetype). If uti is jpeg and types don't match, use ImageConverter to convert image to jpeg and replace the copy in the Photos library (Photos expects all external edits to be type jpeg but double-check that's the expected UTI)

Support --dry-run to see what would be fixed

osxphotos fix --edited-image-type --dry-run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant