-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for the push notification. #65
Conversation
Wanted to try out your fork. But what file does "Step 3 - Configuration" want you to edit? |
Hmm, you don't have to make the configuration file manually it usually just generate default one when you run it for the first time then ask you to edit it before running it again. something like this
and this is what apprise supports supports Also the file that you should edit is config.json, make sure you are using the correct fork tho so basically just pull the one in my repo to try it out in a new folder don't mix it with the Rick one cause that one doesn't read .json instead it's reading .ini |
Strange. When i start a clean master download with |
Nevermind. I found out what was wrong. I clicked the download link in "Step 2 - Download project files" instead of downloading manually, and the link isn't for your fork. |
Ohh cool yea my bad, I made the link as a place holder for the future one if it get merged etc. But yea I was about to let you know to download it directly from the fork :), let me know how it goes anyway or if there should be an improvement because it's not really complete as it will just send it on each run and I think that will get annoying so maybe in the future if I got some free time I will implement the schedule etc. |
Now i keep getting errors tho. Pretty sure i set everything up currectly tho.
|
Fixed it. Just needed to change a "True" to "true" |
ahh glad to hear it, Yea json is a bit tricky but that error is usually just something missing in the json or miss type stuff in json I do recommend JSON Validator. |
I manage to add the push notification support, but had to change the config file basically it's JSON now instead of text file
reason - easier to work with.
But beside that just logging changed custom logger or more like a separate class for logger that we can tweak as much as we like.
I tested it myself but would love to get others to test it before merging the pull request.
the support for the notification is not limited to pushover, added slack and apprise which supports a lot of platform.
I did however tested it with discord notifications.
discord notifs
Also at the moment it's up to the user on whether they want to enable the push notifs or not basically there is a section in the config.json called
"notify_failed_matches"
and if they set this to true it will send notification after each run if it's false then won't send it although now that the config file is json we can just add scheduled notifs etc.There is an option to push notification while it's running but I haven't set it up properly for it but it's just a matter of adding
notify.send(message="Whatever message here or log.info perhaps")