Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separator Type Inconsistency in Chain Concatenation #160

Closed
nevillco opened this issue Jul 8, 2016 · 1 comment
Closed

Separator Type Inconsistency in Chain Concatenation #160

nevillco opened this issue Jul 8, 2016 · 1 comment

Comments

@nevillco
Copy link
Contributor

nevillco commented Jul 8, 2016 •
edited
Loading

Concatenating BONChain with BONText.joinTextables takes a BONChain as a separator, while using BONChain().appendLink takes a String as a separator. Should deprecate current version of appendLink with separator parameter and introduce one with a separatorTextable of type id<BONTextable>.
@ZevEisenberg
Copy link
Collaborator

The documentation also says that joinTextables and appendLink:separator: result in different behaviors for the separator, but they appear not to. Making this change will sidestep the problem by making the separator a fully specified BONTextable.

Also: the parameter should probably be separatorTextable:, since it should take a value of type id<BONTextable>.

@nevillco nevillco mentioned this issue Jul 11, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ZevEisenberg @nevillco