Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: uniswap v4 #608

Open
wants to merge 18 commits into
base: development
Choose a base branch
from
Open

feat: uniswap v4 #608

wants to merge 18 commits into from

Conversation

gabririgo
Copy link
Contributor

@gabririgo gabririgo commented Nov 21, 2024

resolves #609

📓 Overview

Adds the adapter for the Uniswap universal router contracts, which routes swaps through uniswap v4, v4 and v2.

⚠️ Dependencies

Adding Uniswap universal router results in a series of build failures, at repo and contracts level. Most notably, after fixing everything, hardhat cannot successfully compile contracts as returns "Invalid EVM version requested.".
Notice: support for uniswap v4 in uniswap universal router is currently on branch 'dev', but published npm module includes v4 methods. Adding universal router as a git submodule has several complications, starting from need to use branch dev and build from there, which otherwise results in failure with its own deps. We may need to a) write uniswap interfaces and types, mock integration and b) create a separate repo for testing rigoblock and uniswap universal router.
Depends on #CHANGEME

@gabririgo gabririgo added enhancement New feature or request contracts updates contracts folder labels Nov 21, 2024
Copy link

openzeppelin-code bot commented Nov 21, 2024

feat: uniswap v4

Generated at commit: c9b60c51efb56a4f8895adc752eff15af3698e6c

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
1
0
12
40
55
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11975828414

Details

  • 0 of 221 (0.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-14.2%) to 83.791%

Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/protocol/extensions/adapters/lib/uni-v3/BytesLib.sol 0 13 0.0%
contracts/protocol/extensions/adapters/AUniswapRouter.sol 0 55 0.0%
contracts/protocol/extensions/adapters/AUniswapDecoder.sol 0 153 0.0%
Totals Coverage Status
Change from base Build 11948876896: -14.2%
Covered Lines: 1287
Relevant Lines: 1516

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contracts updates contracts folder enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add support for Uniswap v4
2 participants