-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: uniswap v4 #608
Open
gabririgo
wants to merge
18
commits into
development
Choose a base branch
from
feat/uniswap-v4
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: uniswap v4 #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added new extension for uniswap universal router with v4 support
gabririgo
added
enhancement
New feature or request
contracts
updates contracts folder
labels
Nov 21, 2024
feat: uniswap v4
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
adding uniswap contracts results in Invalid EVM version requested. trying fix
fix versions to reconcile correct svm version for each used compiler
Pull Request Test Coverage Report for Build 11975828414Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #609
📓 Overview
Adds the adapter for the Uniswap universal router contracts, which routes swaps through uniswap v4, v4 and v2.
Adding Uniswap universal router results in a series of build failures, at repo and contracts level. Most notably, after fixing everything, hardhat cannot successfully compile contracts as returns "Invalid EVM version requested.".
Notice: support for uniswap v4 in uniswap universal router is currently on branch 'dev', but published npm module includes v4 methods. Adding universal router as a git submodule has several complications, starting from need to use branch dev and build from there, which otherwise results in failure with its own deps. We may need to a) write uniswap interfaces and types, mock integration and b) create a separate repo for testing rigoblock and uniswap universal router.
Depends on #CHANGEME