Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up integration test #14

Merged
merged 2 commits into from
Jan 19, 2017
Merged

Clean up integration test #14

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a3835a
Clean up integration test
asgrim Jan 19, 2017
33a1167
Wrong annotation used - should be coversNothing
asgrim Jan 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions test/unit/CacheIntegrationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,23 +5,24 @@
use Doctrine\Common\Cache\ArrayCache;
use Roave\DoctrineSimpleCache\SimpleCacheAdapter;

/**
* @coversNothing
*/
final class CacheIntegrationTest extends SimpleCacheTest
{
/**
* @return \Psr\SimpleCache\CacheInterface that is used in the tests
*/
public function createSimpleCache()
public function createSimpleCache() : \Psr\SimpleCache\CacheInterface
{
$doctrineCache = new ArrayCache();

return new SimpleCacheAdapter($doctrineCache);
return new SimpleCacheAdapter(new ArrayCache());
}

protected function setUp()
protected function setUp() : void
{
parent::setUp();

// @todo: Let's make these tests passed!
// @todo: Let's make these tests pass
$this->skippedTests['testSetTtl'] = true;
$this->skippedTests['testSetExpiredTtl'] = true;
$this->skippedTests['testSetMultipleTtl'] = true;
Expand Down