diff --git a/dataset/dm_math.py b/dataset/dm_math.py index a0b7590..18763a1 100644 --- a/dataset/dm_math.py +++ b/dataset/dm_math.py @@ -30,7 +30,26 @@ def download(self): f" {os.path.abspath(self.cache_dir)} folder." with tarfile.open(os.path.join(self.cache_dir, "mathematics_dataset-v1.0.tar.gz"), "r") as tf: - tf.extractall(path=self.cache_dir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tf, path=self.cache_dir) def load_file(self, path: str) -> Tuple[List[str], List[str]]: print(f"Loading {path}")