Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColumnTypes contain duplicate union types #217

Open
RobinClowers opened this issue Oct 29, 2024 · 1 comment
Open

ColumnTypes contain duplicate union types #217

RobinClowers opened this issue Oct 29, 2024 · 1 comment

Comments

@RobinClowers
Copy link
Contributor

RobinClowers commented Oct 29, 2024

Using kysely-codegen 0.17.0, I get this diff:

-export type Int8 = ColumnType<string, bigint | number | string>;
+export type Int8 = ColumnType<string, bigint | number | string, bigint | number | string>;

-export type Interval = ColumnType<IPostgresInterval, IPostgresInterval | number | string>;
+export type Interval = ColumnType<IPostgresInterval, IPostgresInterval | number | string, IPostgresInterval | number | string>;

-export type Numeric = ColumnType<string, number | string>;
+export type Numeric = ColumnType<string, number | string, number | string>;

-export type Timestamp = ColumnType<Date, Date | string>;
+export type Timestamp = ColumnType<Date, Date | string, Date | string>;

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@RobinBlomberg
Copy link
Owner

Hey! This was changed due to #203. It is however possible that we still want to deduplicate the types, but in a more correct manner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants