Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loads of functions should be generic #22

Open
RobinHankin opened this issue Jul 7, 2021 · 1 comment
Open

loads of functions should be generic #22

RobinHankin opened this issue Jul 7, 2021 · 1 comment

Comments

@RobinHankin
Copy link
Owner

if you load the mvp package and then the spray package, loads of functions get masked. e.g. in the mvp package, sourcing inst/coercion.R gives:

> source("coercion.R")   # low-level functions, e.g. as.mvp()

Attaching package: ‘spray’

The following objects are masked from ‘package:mvp’:

    aderiv, coeffs, coeffs<-, constant, constant<-, homog, is.zero,
    knight, linear, nterms, ooom, product, subs, xyz

The following objects are masked from ‘package:base’:

    pmax, pmin

It would be good to make at least some of the masked functions generic.

@RobinHankin
Copy link
Owner Author

some of these are already generic in the spray package but not the mvp package, where I will raise a new issue. But it would be good to genericalize is.zero() and possibly subs().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant