diff --git a/rosbridge_library/src/rosbridge_library/capabilities/fragmentation.py b/rosbridge_library/src/rosbridge_library/capabilities/fragmentation.py index a5b582034..947eeb704 100644 --- a/rosbridge_library/src/rosbridge_library/capabilities/fragmentation.py +++ b/rosbridge_library/src/rosbridge_library/capabilities/fragmentation.py @@ -76,8 +76,6 @@ def fragment(self, message, fragment_size, mid=None): if message_length <= fragment_size: return [message] - msg_id = message.get("id", None) - expected_duration = int(math.ceil(math.ceil(message_length / float(fragment_size))) * self.protocol.delay_between_messages) log_msg = "sending " + str(int(math.ceil(message_length / float(fragment_size)))) + " parts [fragment size: " + str(fragment_size) +"; expected duration: ~" + str(expected_duration) + "s]" diff --git a/rosbridge_library/test/capabilities/test_call_service.py b/rosbridge_library/test/capabilities/test_call_service.py index d91f85f27..7098321a9 100755 --- a/rosbridge_library/test/capabilities/test_call_service.py +++ b/rosbridge_library/test/capabilities/test_call_service.py @@ -70,8 +70,7 @@ def cb(msg, cid=None): def test_call_service_fail(self): # Dummy service that instantly fails - service_server = rospy.Service("set_bool_fail", SetBool, - lambda req: None) + _ = rospy.Service("set_bool_fail", SetBool, lambda req: None) proto = Protocol("test_call_service_fail") s = CallService(proto) diff --git a/rosbridge_library/test/experimental/complex_srv+tcp/test_non-ros_service_server_complex-srv.py b/rosbridge_library/test/experimental/complex_srv+tcp/test_non-ros_service_server_complex-srv.py index 7d6dc494a..72ddefef0 100755 --- a/rosbridge_library/test/experimental/complex_srv+tcp/test_non-ros_service_server_complex-srv.py +++ b/rosbridge_library/test/experimental/complex_srv+tcp/test_non-ros_service_server_complex-srv.py @@ -34,7 +34,7 @@ def calculate_service_response(request): request_object = json.loads(request) # parse string for service request - args = request_object["args"] # get parameter field (args) +# args = request_object["args"] # get parameter field (args) # count = int(args["count"] ) # get parameter(s) as described in corresponding ROS srv-file # # message = "" # calculate service response diff --git a/rosbridge_server/scripts/rosbridge_websocket.py b/rosbridge_server/scripts/rosbridge_websocket.py index 9424fd330..0d4935f52 100755 --- a/rosbridge_server/scripts/rosbridge_websocket.py +++ b/rosbridge_server/scripts/rosbridge_websocket.py @@ -191,7 +191,7 @@ def __init__(self): if "--unregister_timeout" in sys.argv: idx = sys.argv.index("--unregister_timeout") + 1 if idx < len(sys.argv): - unregister_timeout = float(sys.argv[idx]) + RosbridgeWebSocket.unregister_timeout = float(sys.argv[idx]) else: print("--unregister_timeout argument provided without a value.") sys.exit(-1) diff --git a/rosbridge_server/src/rosbridge_server/udp_handler.py b/rosbridge_server/src/rosbridge_server/udp_handler.py index e60cd11d0..b1c17f7ea 100644 --- a/rosbridge_server/src/rosbridge_server/udp_handler.py +++ b/rosbridge_server/src/rosbridge_server/udp_handler.py @@ -1,6 +1,5 @@ import rospy from rosbridge_library.rosbridge_protocol import RosbridgeProtocol -from rosbridge_library.util import bson from twisted.internet.protocol import DatagramProtocol @@ -66,7 +65,6 @@ def stopProtocol(self): cls.client_count_pub.publish(cls.clients_connected) rospy.loginfo("Client disconnected. %d clients total.", cls.clients_connected) def send_message(self, message): - binary = isinstance(message, bson.BSON) self.write(message) def check_origin(self, origin): return False diff --git a/setup.cfg b/setup.cfg index 77879a209..35b53629f 100644 --- a/setup.cfg +++ b/setup.cfg @@ -5,5 +5,5 @@ ignore-words-list = miror count = True max-complexity = 36 max-line-length = 228 -select = C,E262,E266,E4,E5,E7,E9,F4,F5,F6,F7,F81,F82,F83,F9,W1,W6 +select = C,E262,E266,E4,E5,E7,E9,F,W1,W6 show-source = True