[IMPROVE] System messages consistency #4461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reinaldonetof
suggested changes
Sep 15, 2022
There was a problem hiding this comment.
It's missing 'ru', 'au', 'user-muted', 'user-unmuted', 'r', 'room_changed_privacy', 'room_changed_avatar', 'room_e2e_enabled', 'room_e2e_disabled', 'room-removed-set-only', 'room-set-read-only', 'room-dissalowed-reacting', 'room-allowed-reacting', inside SYSTEM_MESSAGE_TYPES_WITH_AUTHOR_NAME
'room_archived', 'user-muted' isn't working
reinaldonetof
suggested changes
Oct 4, 2022
Co-authored-by: Reinaldo Neto <47038980+reinaldonetof@users.noreply.github.com>
reinaldonetof
approved these changes
Oct 5, 2022
diegolmello
pushed a commit
that referenced
this pull request
Dec 2, 2022
* fix sys messages * update snapshot * update snapshot * add username * wip * wip * change to switch and fix types * wip * new translations * update snapshot * Update app/containers/message/utils.ts Co-authored-by: Reinaldo Neto <47038980+reinaldonetof@users.noreply.github.com> * fix types and return * remove unused translation * fix types * remove unused params * minor tweak * update story Co-authored-by: Reinaldo Neto <47038980+reinaldonetof@users.noreply.github.com> Co-authored-by: Reinaldo Neto <reinaldonetof@hotmail.com>
diegolmello
pushed a commit
that referenced
this pull request
Dec 2, 2022
* fix sys messages * update snapshot * update snapshot * add username * wip * wip * change to switch and fix types * wip * new translations * update snapshot * Update app/containers/message/utils.ts Co-authored-by: Reinaldo Neto <47038980+reinaldonetof@users.noreply.github.com> * fix types and return * remove unused translation * fix types * remove unused params * minor tweak * update story Co-authored-by: Reinaldo Neto <47038980+reinaldonetof@users.noreply.github.com> Co-authored-by: Reinaldo Neto <reinaldonetof@hotmail.com>
ivnxyz
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
* fix sys messages * update snapshot * update snapshot * add username * wip * wip * change to switch and fix types * wip * new translations * update snapshot * Update app/containers/message/utils.ts Co-authored-by: Reinaldo Neto <47038980+reinaldonetof@users.noreply.github.com> * fix types and return * remove unused translation * fix types * remove unused params * minor tweak * update story Co-authored-by: Reinaldo Neto <47038980+reinaldonetof@users.noreply.github.com> Co-authored-by: Reinaldo Neto <reinaldonetof@hotmail.com>
ivnxyz
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
* fix sys messages * update snapshot * update snapshot * add username * wip * wip * change to switch and fix types * wip * new translations * update snapshot * Update app/containers/message/utils.ts Co-authored-by: Reinaldo Neto <47038980+reinaldonetof@users.noreply.github.com> * fix types and return * remove unused translation * fix types * remove unused params * minor tweak * update story Co-authored-by: Reinaldo Neto <47038980+reinaldonetof@users.noreply.github.com> Co-authored-by: Reinaldo Neto <reinaldonetof@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
System messages consistency
Related: RocketChat/Rocket.Chat#26130
Issue(s)
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments
Jira: TC-88