From 579639bbd1a6f0030bd75fd49ed0f9efbc4c7d5d Mon Sep 17 00:00:00 2001 From: murtaza98 Date: Fri, 24 Jun 2022 11:38:08 +0530 Subject: [PATCH] suggestions for PR #25993 --- apps/meteor/server/startup/migrations/v270.ts | 6 ++---- packages/core-typings/src/IVoipExtension.ts | 2 +- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/apps/meteor/server/startup/migrations/v270.ts b/apps/meteor/server/startup/migrations/v270.ts index 78ffe5e59257..c35076be6958 100644 --- a/apps/meteor/server/startup/migrations/v270.ts +++ b/apps/meteor/server/startup/migrations/v270.ts @@ -1,13 +1,11 @@ -import { MongoInternals } from 'meteor/mongo'; +import { Settings } from '@rocket.chat/models'; import { addMigration } from '../../lib/migrations'; addMigration({ version: 270, async up() { - const { mongo } = MongoInternals.defaultRemoteCollectionDriver(); - const settings = mongo.db.collection('rocketchat_settings'); - await settings.deleteMany({ + await Settings.deleteMany({ _id: { $in: ['VoIP_Server_Host', 'VoIP_Server_Websocket_Port'], }, diff --git a/packages/core-typings/src/IVoipExtension.ts b/packages/core-typings/src/IVoipExtension.ts index 9a32cdc0fa00..805830fb679a 100644 --- a/packages/core-typings/src/IVoipExtension.ts +++ b/packages/core-typings/src/IVoipExtension.ts @@ -50,4 +50,4 @@ export const isIExtensionDetails = (prop: any): prop is IExtensionDetails => prop.extension !== undefined && prop.password !== undefined && prop.authtype !== undefined && prop.state !== undefined; export const isIRegistrationInfo = (prop: any): prop is IRegistrationInfo => - prop.hasOwnProperty('host') && prop.hasOwnProperty('callServerConfig') && prop.hasOwnProperty('extensionDetails'); + prop.hasOwnProperty('callServerConfig') && prop.hasOwnProperty('extensionDetails');