Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Upgrade ESLint #26132

Merged
merged 7 commits into from
Jul 22, 2022
Merged

Chore: Upgrade ESLint #26132

merged 7 commits into from
Jul 22, 2022

Conversation

tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Jul 5, 2022

Proposed changes (including videos or screenshots)

Upgrade ESLint (to 8.19.0) and its dependencies, dropping outdated rules.

Issue(s)

Steps to test or reproduce

Further comments

@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Jul 8, 2022
@tassoevan tassoevan marked this pull request as ready for review July 8, 2022 22:34
@tassoevan tassoevan requested review from a team as code owners July 8, 2022 22:34
d-gubert
d-gubert previously approved these changes Jul 11, 2022
Copy link
Member

@d-gubert d-gubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good on Apps-Engine side

apps/meteor/ee/client/.eslintrc.json Outdated Show resolved Hide resolved
apps/meteor/client/.eslintrc.json Show resolved Hide resolved
sampaiodiego
sampaiodiego previously approved these changes Jul 15, 2022
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Jul 22, 2022

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Jul 22, 2022
@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Jul 22, 2022
@ggazzo ggazzo merged commit bff5d48 into develop Jul 22, 2022
@ggazzo ggazzo deleted the chore/up-eslint branch July 22, 2022 16:10
TimiBolu added a commit to TimiBolu/Rocket.Chat that referenced this pull request Jul 22, 2022
gabriellsh added a commit that referenced this pull request Jul 26, 2022
* 'develop' of github.com:RocketChat/Rocket.Chat: (294 commits)
  Chore: Convert UserCardWithData to ts (#26192)
  Chore: cleanup startup of test and put wizard in setup function (#26306)
  Chore: Convert AccountPreferencesPage to ts (#26096)
  [FIX] Missing bio field UI validation (#26345)
  Chore: Remove square prop from IconButton (#26343)
  Chore: Rewrite VerticalBarOldActions to TS (#26277)
  Chore: Replace direct multiple icon (#26342)
  Chore: Upgrade ESLint (#26132)
  Chore: convert autotranslate to ts (#25953)
  Chore: Change some places still using fields to projection (#26308)
  Bump version to 5.1.0-develop
  Bump version to 5.0.0
  Bump version to 5.0.0-rc.12
  Regression: Livechat not rendering UiKit messages with action buttons (#26327)
  Chore: bump fuselage packages (#26325)
  Chore: Update useSidebarPalette selectors (#26322)
  Regression: Fix get myself user data (#26328)
  Bump version to 5.0.0-rc.11
  Bump version to 4.8.2
  Regression: fix `directory` endpoint not listing teams (#26310)
  ...
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants