Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Tests intermitences #26464

Merged
merged 3 commits into from
Aug 4, 2022
Merged

Chore: Tests intermitences #26464

merged 3 commits into from
Aug 4, 2022

Conversation

weslley543
Copy link
Contributor

  • Fix tests intermitences

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #26464 (c61fe3a) into develop (6b4ae48) will decrease coverage by 1.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #26464      +/-   ##
===========================================
- Coverage    39.11%   38.08%   -1.04%     
===========================================
  Files          749      745       -4     
  Lines        18653    18622      -31     
  Branches      1425     1418       -7     
===========================================
- Hits          7296     7092     -204     
- Misses       11133    11311     +178     
+ Partials       224      219       -5     
Flag Coverage Δ
e2e 38.08% <ø> (-1.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apps/meteor/app/ui/client/lib/UserCard.js 14.28% <0.00%> (-82.15%) ⬇️
...meteor/client/lib/portals/createEphemeralPortal.ts 33.33% <0.00%> (-66.67%) ⬇️
...r/client/startup/notifications/usersNameChanged.ts 33.33% <0.00%> (-66.67%) ⬇️
...nt/views/admin/settings/hooks/useSettingsGroups.ts 5.00% <0.00%> (-60.00%) ⬇️
apps/meteor/app/e2e/client/events.js 50.00% <0.00%> (-50.00%) ⬇️
apps/meteor/lib/getUserEmailAddress.ts 50.00% <0.00%> (-50.00%) ⬇️
...ps/meteor/client/lib/utils/getUserEmailVerified.ts 50.00% <0.00%> (-50.00%) ⬇️
...s/meteor/client/lib/portals/portalsSubscription.ts 47.61% <0.00%> (-47.62%) ⬇️
apps/meteor/client/startup/usersObserve.ts 58.33% <0.00%> (-41.67%) ⬇️
apps/meteor/client/views/root/PortalWrapper.ts 0.00% <0.00%> (-40.00%) ⬇️
... and 56 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@weslley543 weslley543 marked this pull request as ready for review August 4, 2022 13:35
@weslley543 weslley543 requested a review from a team as a code owner August 4, 2022 13:35
@ggazzo ggazzo changed the title [FIX] tests intermitences Chore: Tests intermitences Aug 4, 2022
@ggazzo ggazzo merged commit 1cb8101 into develop Aug 4, 2022
@ggazzo ggazzo deleted the fix/test-intermitences branch August 4, 2022 13:37
weslley543 added a commit that referenced this pull request Aug 4, 2022
gabriellsh added a commit that referenced this pull request Aug 4, 2022
…ove-e2ee-threadlist

* 'develop' of github.com:RocketChat/Rocket.Chat: (200 commits)
  [FIX] Undefined MediaDevices error on HTTP (#26396)
  Chore: Codecov threshold (#26477)
  Chore: Tests intermitences (#26464)
  [FIX] Don't give errors on outbound voip call Request Terminated (#26373)
  Chore: Use Docker compose on CI (#26437)
  [FIX] DialPad call button from end to center (#26459)
  Chore: Parallelize e2e tests (#26390)
  [IMPROVE] use enter key to call using DialPad (#26454)
  Chore: Accounts/token to TS (#26434)
  Chore: Purge some unused modules (#26447)
  i18n: Language update from LingoHub 🤖 on 2022-08-01Z (#26429)
  Chore: Add end-to-end tests to teams listing in the `directory` endpoint (#26347)
  Chore: Cache playwright (#26432)
  [FIX] Empty results on `im.list` endpoint (#26438)
  [IMPROVE] Upgrade nivo and React Query (#26338)
  Chore: Upgrade Fuselage packages to next dist-tag (#26435)
  Chore: Omnichannel endpoints e2e tests (#26376)
  Chore: Refactor UserInfo to typescript (#26323)
  Chore: Rewrite Location modal to React (#26196)
  Chore: Rewrite SaveToWebdav Modal to React Component (#24365)
  ...
gabriellsh added a commit that referenced this pull request Aug 8, 2022
…homepage

* 'develop' of github.com:RocketChat/Rocket.Chat: (39 commits)
  Chore: ESLint warnings (#26504)
  Chore: Remove settings Fibers usage (#26465)
  Chore: Refactor create-target-channel util (#26493)
  Chore: useEndpointData deprecation (#26494)
  [NEW] Surface featured apps endpoint  (#26416)
  [FIX] Request at least one field in the payload of `/v1/users.setStatus` (#26490)
  Chore: Exit process on `unhandledRejection` on CI (#26467)
  [FIX] Clear push token on save user password (#26466)
  [FIX] Undefined MediaDevices error on HTTP (#26396)
  Chore: Codecov threshold (#26477)
  Chore: Tests intermitences (#26464)
  [FIX] Don't give errors on outbound voip call Request Terminated (#26373)
  Chore: Use Docker compose on CI (#26437)
  [FIX] DialPad call button from end to center (#26459)
  Chore: Parallelize e2e tests (#26390)
  [IMPROVE] use enter key to call using DialPad (#26454)
  Chore: Accounts/token to TS (#26434)
  Chore: Purge some unused modules (#26447)
  i18n: Language update from LingoHub 🤖 on 2022-08-01Z (#26429)
  Chore: Add end-to-end tests to teams listing in the `directory` endpoint (#26347)
  ...
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants