[IMPROVE] Remove device-management banner and modal #26729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #26729 +/- ##
===========================================
+ Coverage 40.58% 40.65% +0.06%
===========================================
Files 799 799
Lines 18309 18300 -9
Branches 1957 1954 -3
===========================================
+ Hits 7431 7439 +8
+ Misses 10579 10567 -12
+ Partials 299 294 -5
Flags with carried forward coverage won't be shown. Click here to find out more. |
filipemarins
approved these changes
Aug 31, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
Not removing the banner_dismiss records related to device-management as we can reuse this info in future if we decide some other flow for this feature, if not will have make sure that we remove these records as well.