Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Importer fails when file includes user without an email. #26836

Merged
merged 3 commits into from
Sep 13, 2022
Merged

[FIX] Importer fails when file includes user without an email. #26836

merged 3 commits into from
Sep 13, 2022

Conversation

pierre-lehnen-rc
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Closes #26479

Steps to test or reproduce

Further comments

@pierre-lehnen-rc pierre-lehnen-rc requested a review from a team as a code owner September 8, 2022 21:38
@codecov
Copy link

codecov bot commented Sep 8, 2022 •
edited
Loading

Codecov Report

Merging #26836 (f970aee) into develop (ddd1e87) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head f970aee differs from pull request most recent head 0503ba5. Consider uploading reports for the commit 0503ba5 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26836      +/-   ##
===========================================
+ Coverage    40.58%   40.62%   +0.03%     
===========================================
  Files          791      791              
  Lines        17901    17901              
  Branches      1927     1927              
===========================================
+ Hits          7266     7272       +6     
+ Misses       10344    10337       -7     
- Partials       291      292       +1
Flag Coverage Δ
e2e 40.62% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@KIRIN178
Copy link

@pierre-lehnen-rc
merge failed....

@debdutdeb
Copy link
Member

@KIRIN178 sorry, what merge failed?

@KIRIN178
Copy link

KIRIN178 commented Sep 12, 2022 •
edited
Loading

圖片
@debdutdeb It shows "Merging is blocked."

@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Sep 13, 2022
@kodiakhq kodiakhq bot merged commit ddd52cb into develop Sep 13, 2022
@kodiakhq kodiakhq bot deleted the fix/importer-types branch September 13, 2022 21:15
DarinDev1000
DarinDev1000 reviewed Sep 13, 2022
View reviewed changes
Copy link

@DarinDev1000 DarinDev1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this works to allow bot users to be imported

@d-gubert d-gubert added this to the 5.1.2 milestone Sep 14, 2022
@shaymdev shaymdev mentioned this pull request Sep 14, 2022
Merged
@tassoevan tassoevan mentioned this pull request Sep 14, 2022
Closed
tassoevan pushed a commit that referenced this pull request Sep 21, 2022
@pierre-lehnen-rc @tassoevan
[FIX] Importer fails when file includes user without an email. (#26836)
5689e99
@tassoevan tassoevan mentioned this pull request Sep 21, 2022
Merged
tassoevan pushed a commit that referenced this pull request Sep 22, 2022
@pierre-lehnen-rc @tassoevan
[FIX] Importer fails when file includes user without an email. (#26836)
f5de1f3
tassoevan pushed a commit that referenced this pull request Sep 23, 2022
@pierre-lehnen-rc @tassoevan
[FIX] Importer fails when file includes user without an email. (#26836)
05a4b18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarinDev1000 DarinDev1000 DarinDev1000 left review comments

@ggazzo ggazzo ggazzo approved these changes

Assignees
No one assigned
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
5.1.3
Development

Successfully merging this pull request may close these issues.

Slack import fails with Failed to start import operation
6 participants
@pierre-lehnen-rc @KIRIN178 @debdutdeb @ggazzo @DarinDev1000 @d-gubert