Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Hide generated PDF on Livechat upon chat close #27932

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

filipemarins
Copy link
Contributor

@filipemarins filipemarins commented Feb 1, 2023

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Clear chat listeners when the conversation is closed.

@filipemarins filipemarins marked this pull request as ready for review February 1, 2023 21:14
@filipemarins filipemarins requested review from a team as code owners February 1, 2023 21:14
@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Merging #27932 (644add2) into feat/chat-transcript (817484f) will decrease coverage by 1.19%.
The diff coverage is n/a.

Impacted file tree graph

@@                   Coverage Diff                    @@
##           feat/chat-transcript   #27932      +/-   ##
========================================================
- Coverage                 43.07%   41.89%   -1.19%     
========================================================
  Files                       819      841      +22     
  Lines                     17030    17626     +596     
  Branches                   2003     2071      +68     
========================================================
+ Hits                       7336     7384      +48     
- Misses                     9413     9965     +552     
+ Partials                    281      277       -4     
Flag Coverage Δ
e2e 41.89% <ø> (-1.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@filipemarins filipemarins merged commit 8bbcfc6 into feat/chat-transcript Feb 7, 2023
@filipemarins filipemarins deleted the oc-619 branch February 7, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants