Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Refactor AudioMessageRecorder #28019

Merged
merged 2 commits into from
Feb 14, 2023

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Feb 13, 2023

Proposed changes (including videos or screenshots)

DSA-11

Kapture 2023-02-13 at 17 24 54

Issue(s)

Steps to test or reproduce

Further comments

@dougfabris dougfabris requested a review from a team as a code owner February 13, 2023 20:25
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Feb 13, 2023
@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #28019 (7a3832a) into develop (82aa967) will increase coverage by 0.95%.
The diff coverage is 0.00%.

❗ Current head 7a3832a differs from pull request most recent head 0afaeec. Consider uploading reports for the commit 0afaeec to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28019      +/-   ##
===========================================
+ Coverage    41.67%   42.62%   +0.95%     
===========================================
  Files          826      800      -26     
  Lines        16947    16468     -479     
  Branches      2073     1999      -74     
===========================================
- Hits          7062     7020      -42     
+ Misses        9606     9173     -433     
+ Partials       279      275       -4     
Flag Coverage Δ
e2e 42.62% <0.00%> (+0.95%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@kodiakhq kodiakhq bot merged commit e5055f0 into develop Feb 14, 2023
@kodiakhq kodiakhq bot deleted the chore/refactor-audioMessageRecorder branch February 14, 2023 00:22
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@dougfabris dougfabris added this to the 6.0.0 milestone Feb 23, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants