Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crash on ios plugin v8.0.3 #347

Closed
heshesh2010 opened this issue Jul 5, 2024 · 8 comments
Closed

crash on ios plugin v8.0.3 #347

heshesh2010 opened this issue Jul 5, 2024 · 8 comments
Labels
bug Something isn't working

Comments

@heshesh2010
Copy link

Hi , when I create share link on ios real device i got the attached error in xcode log

Screenshot 2024-07-06 at 1 12 07 AM

flutter doctor

Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.22.2, on macOS 14.5 23F79 darwin-x64, locale en-EG)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2023.2)
[✓] VS Code (version 1.90.2)
[✓] Connected device (3 available)
[✓] Network resources

• No issues found!
@heshesh2010 heshesh2010 added the bug Something isn't working label Jul 5, 2024
@RodrigoSMarques
Copy link
Owner

Please do not remove the additional information that is requested when opening the issue, otherwise your issue will be closed due to lack of detailed information.

Which package version? Which operating system version?

Did you call FlutterBranchSdk.validateSDKIntegration() in your project? Did the result return successfully?

From your screenshot, both the error and url variables are null. This condition should never occur.

Your project has some configuration error.

@heshesh2010
Copy link
Author

Please do not remove the additional information that is requested when opening the issue, otherwise your issue will be closed due to lack of detailed information.

Which package version? Which operating system version?

Did you call FlutterBranchSdk.validateSDKIntegration() in your project? Did the result return successfully?

From your screenshot, both the error and url variables are null. This condition should never occur.

Your project has some configuration error.

hi,

running on plugin v8.0.3
ios device v : 17.5.1

Did you call FlutterBranchSdk.validateSDKIntegration() in your project? Did the result return successfully?
yes, see the screenshot
IMG_4667

@RodrigoSMarques
Copy link
Owner

RodrigoSMarques commented Jul 6, 2024 •
edited
Loading

your project's uri scheme is strange. should be displayed as in the example

image

Not "https"

@heshesh2010
Copy link
Author

Hi ,

It was working before and here is branch dashboard configs

image

@RodrigoSMarques
Copy link
Owner

In my opinion, https is not a schema for an application. it should be the name of the Application or similar to the name. This may be causing an error in the branch's SDK. my first suggestion would be to review the Dashboard and project settings to change this.

@RodrigoSMarques
Copy link
Owner

If the problem persists after the change, you will have to open an issue with Branch. As the SDK is returning an error, only they can evaluate it.

@heshesh2010
Copy link
Author

heshesh2010 commented Jul 6, 2024 •
edited
Loading

If the problem persists after the change, you will have to open an issue with Branch. As the SDK is returning an error, only they can evaluate it.

changed the url scheme and I got same error

IMG_4668

RodrigoSMarques added a commit that referenced this issue Jul 12, 2024
@RodrigoSMarques
Release 8.04
1562a72 
## 8.0.4
### ⚠️ BREAKING CHANGE
This is a major release which contains breaking API changes.
#### ⚠️ SDK Initialization Changed
* `useTestKey` parameter is no longer supported at `FlutterBranchSdk.init()`.

Check the instructions in `README.MD` on how to activate the `key_test_`.

### 🐛 Bug Fixes
* Fix issue #347: ios plugin v8.0.3 crashes when no url is returned
* Fix issue #338: Changing the return value in didFinishLaunchingWithOptions crashes the application from SDK version above 8.0.0
@RodrigoSMarques RodrigoSMarques mentioned this issue Jul 12, 2024
Merged
@RodrigoSMarques
Copy link
Owner

Code correction made to avoid crash if the URL is not returned

Available in version 8.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@heshesh2010 @RodrigoSMarques