Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#98 assertEqualsFixture add reference to assertable fixture to error message #111

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Adil9994
Copy link
Contributor

@Adil9994 Adil9994 commented Apr 1, 2024

No description provided.

@Adil9994 Adil9994 requested a review from DenTray April 1, 2024 19:20
@Adil9994 Adil9994 self-assigned this Apr 1, 2024
@DenTray
Copy link
Collaborator

DenTray commented Apr 3, 2024

@Adil9994 please try to cover these changes by test cases

$this->assertEquals($this->getJsonFixture($fixture), $data);
$fixturePath = $this->getFixturePath($fixture);

$assertFailedMessage = "Failed asserting that the provided data equal to \"{$fixturePath}:1\" fixture.";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$assertFailedMessage = "Failed asserting that the provided data equal to \"{$fixturePath}:1\" fixture.";
$assertFailedMessage = "Failed asserting that the provided data equal to \"{$fixturePath}\" fixture.";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants