#140: Global export mode not affect for email testing #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aizlee
requested changes
Dec 6, 2024
aizlee
approved these changes
Dec 9, 2024
DenTray
requested changes
Dec 9, 2024
DenTray
requested changes
Dec 12, 2024
| $this->mockedMail('test@mail.com', 'test_mail_with_global_export.html', 'Test Subject'), | ||
| ]); | ||
|
|
||
| $this->assertFileExists($this->getFixturePath('test_mail_with_export.html')); |
There was a problem hiding this comment.
why you checking test_mail_with_export.html file, but asserting content with the test_mail_with_global_export.html?
| @@ -0,0 +1,3 @@ | |||
| <div> | |||
There was a problem hiding this comment.
you using this fixture to check that globa export mode works fine and create file if it not exists. If you'll commit this file to git - test will always be successful completed even if global export mode will be broken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#140