From 2f23d32d421ec926b48f8d9a44c15b43205dfff8 Mon Sep 17 00:00:00 2001 From: Miguel Ojeda Date: Sun, 21 Mar 2021 22:31:24 +0100 Subject: [PATCH] Remove wrong sentence about mangling in `v0` scheme @bjorn3 helpfully noted that symbols do not stay the same across `rustc` compiler versions. The overall sentence is anyway a bit misleading, because the "hard" requirement is the second one: mixing `rustc` compiler versions is not something we will support. IIRC I was thinking about possible patch level fixes to `rustc` stable versions when I wrote that. Link: https://github.com/Rust-for-Linux/linux/pull/52#discussion_r598094152 Signed-off-by: Miguel Ojeda --- rust/exports.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/rust/exports.c b/rust/exports.c index 900dc3090dd617..f68022bac293d9 100644 --- a/rust/exports.c +++ b/rust/exports.c @@ -4,9 +4,8 @@ // the entire `include/linux/export.h` logic in Rust. // // This requires the Rust's new/future `v0` mangling scheme because the default -// one ("legacy") 1) uses a hash suffix which cannot be predicted across -// compiler versions and 2) uses invalid characters for C identifiers -// (thus we cannot use the `EXPORT_SYMBOL_*` macros). +// one ("legacy") uses invalid characters for C identifiers (thus we cannot use +// the `EXPORT_SYMBOL_*` macros). #include