Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can the elliptic-curve hazmat feature be removed? #1597

Closed
mgeisler opened this issue Jun 24, 2024 · 2 comments · Fixed by #1599
Closed

Can the elliptic-curve hazmat feature be removed? #1597

mgeisler opened this issue Jun 24, 2024 · 2 comments · Fixed by #1599

Comments

@mgeisler
Copy link
Contributor

Hi there,

While vendoring this code, an internal reviewer asked me about the use of the hazmat feature in elliptic-curve: it looks unused.

Would it make sense to remove it, or do you have it for consistency with the other crates?

@tarcieri
Copy link
Member

I believe you're correct. It previously gated a small amount of functionality only intended to be used by implementations of elliptic curves, but those have since been removed.

mgeisler added a commit to mgeisler/rustcrypto-traits that referenced this issue Jun 24, 2024
@mgeisler
Copy link
Contributor Author

Alright! I crated #1599 for this. It will be a breaking change, but maybe that's okay since the crate is at version 0.14.0 right now.

mgeisler added a commit to mgeisler/rustcrypto-traits that referenced this issue Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants