Fix Clippy lints #1598
Fix Clippy lints #1598
Conversation
| @@ -503,6 +503,7 @@ where | |||
| } | |||
|
|
|||
| #[cfg(feature = "pem")] | |||
| #[allow(clippy::to_string_trait_impl)] | |||
There was a problem hiding this comment.
@tarcieri
Maybe it's better remove ToString implementations? The trait docs state the following:
This trait is automatically implemented for any type which implements the Display trait. As such, ToString shouldn’t be implemented directly: Display should be implemented instead, and you get the ToString implementation for free.
But implementing Display on top of to_public_key_pem would look really wrong.
There was a problem hiding this comment.
There is currently no way to use core::fmt::Formatter to serialize PEM, so ToString is the only option here.
You could potentially open an issue to add such support, but pem-rfc7468 is designed around constant-time operation (not really important here due to it being a public key).
There was a problem hiding this comment.
I mean, why have this implementation in the first place? Users should prefer using the to_public_key_pem method since it explicitly states how serialization is performed. IIUC ToString intended for user-facing serialization and PEM serialization arguably barely fits here.
There was a problem hiding this comment.
I will leave the implementation as is, but I think it may be worth to remove it in a separate PR.
No description provided.