feat: Add more details to ParamValueInvalid and introduce SaltInvalid error
#713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
reviewed
Aug 24, 2021
tarcieri
reviewed
Aug 24, 2021
tarcieri
reviewed
Aug 24, 2021
… value; refactor Salt errors
Member
|
Looks good now, thank you! I will go ahead and merge this with the goal of including it in a breaking |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
As briefly discussed in #706 this PR:
Error::ParamValueInvalidin from ofParamValueErrorenum.Error::SaltInvalid.Error::ParamValueInvalidto proper salt error.Also as discussed in the issue this is a breaking change.
Notes
ParamValueErrorcould be an anOptioninParamValueInvalid:ParamValueInvalid(Option<ParamValueError>)if in some cases we do not want to specify a more detailed error but it might be more cumbersome to handle and I am not sure if there is such need, therefore, I went for implementation without it. Just wanted to highlight it as my knowledge here is limited.Fixes: #706