Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very slow performance on Mario & Luigi: Brothership #452

Open
SgtPepperman opened this issue Dec 26, 2024 · 4 comments
Open

Very slow performance on Mario & Luigi: Brothership #452

SgtPepperman opened this issue Dec 26, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@SgtPepperman
Copy link

SgtPepperman commented Dec 26, 2024

Description of the issue

The emulator runs very slow (specially with Vulkan, when switching to OpenGL improves at times).
My system can run pretty much any other Switch game without flaw.
I think it may be a memory leak.

Reproduction steps

When using Vulkan, the issue of the FPS drops is constant from the get go.
On the other hand, OpenGL allows for better performance on 30 FPS, then drops and stays like that for a while, then goes up, and so forth.

Log file

Ryujinx_1.2.78_2024-12-26_14-56-11.log
Ryujinx_1.2.78_2024-12-26_15-06-05.log

OS

Windows 11

Ryujinx version

1.2.78

Game version

1.0.0

CPU

Intel Core i5 12400

GPU

NVIDIA GeForce GTX 1650

RAM

16 GB

List of applied mods

None

Additional context?

image

@SgtPepperman SgtPepperman added the bug Something isn't working label Dec 26, 2024
@GreemDev
Copy link
Member

bad performance does not automatically mean memory leak, please look up terms you don't know before using them

@SgtPepperman
Copy link
Author

please look up terms you don't know before using them

Thanks for looking upon my report, but also was it necessary to be so harsh to me? Sorry for my misplaced conjecture.

@Sam-Man16
Copy link

Sam-Man16 commented Dec 31, 2024

I am getting abnormal performance dips in this game as well. There is a 50/50 chance in battles that framerates will just be halved. This frame dip either ends after the enemies are defeated or can persist for multiple minutes before returning to normal. Not sure what is causing it as my system CPU/RAM/GPU are not running bottlenecked in task manager. I am running the game on Vulkan, I tried switching to OpenGL but the game became overly bright with almost every light source becoming washed out with brightness. EDIT: Also, when the camera pans around in cutscenes or gameplay, sometimes the background graphics overlay the normal graphics causing weird flashing and artifacting.

@entut1
Copy link

entut1 commented Dec 31, 2024

the brutal performance dips happen in my case as well. sometimes trimming Ryujinx's memory with Process Lasso can solve them but not always immeditately. @gr3ger seems to have found a bunch of memory-related issues happening in Ryujinx that affect this game. Some of them lead to memory adresses not aligning properly, which causes issues both in OpenGL and Vulkan, but that mostly caused flickering. It wouldn't be too surprising if there's more stuff like that which leads to corruption and leaks further down the line. Hard to say when this will be fixed for now, as it doesn't seem like there's enough people with the knowledge to fix this stuff out there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants