Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change remoting parameter to allow adding new options #110

Closed
theimowski opened this issue Jun 27, 2018 · 3 comments
Closed

Change remoting parameter to allow adding new options #110

theimowski opened this issue Jun 27, 2018 · 3 comments
Labels
Status: In Progress Type: Enhancement
Milestone
1.0

Comments

@theimowski
Copy link
Member

Related to #107

I'd vote for changing the boolean --remoting parameter to choice parameter with a catchy name (how about --link ?) and remoting as the only option for now.

So instead of dotnet new SAFE --remoting one would type dotnet new SAFE --link remoting

This will allow adding easily support for Elmish.Bridge in future, without "breaking" CLI invocation
@theimowski theimowski added this to the 1.0 milestone Jun 27, 2018
@theimowski theimowski mentioned this issue Jun 27, 2018
Closed
@isaacabraham
Copy link
Member

Will there be the option to add both bridge and remoting together?

@Nhowka
Copy link

Nhowka commented Aug 4, 2018

Could be. The main problem is having the room without changing the counter. Maybe adding a new feature only when bridge is used with remoting could be an option.

theimowski added a commit to theimowski/SAFE-template that referenced this issue Aug 16, 2018
@theimowski
Change 'remoting' to 'communication' - references SAFE-Stack#110
a98b29f
theimowski added a commit that referenced this issue Sep 25, 2018
@theimowski
Merge pull request #143 from theimowski/communication_parameter
099eddc 
Change 'remoting' to 'communication' - references #110
@theimowski
Copy link
Member Author

Closed by #143

@Nhowka Nhowka mentioned this issue Nov 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: In Progress Type: Enhancement
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
3 participants
@isaacabraham @theimowski @Nhowka