Fake target InstallDotNetCore

[MangelMaxime]

Do we really need the InstallDotNetCore target ?

If the user want to use the template they need to have dotnet already installed. I am asking because, when contributing to a new project this is really painful to have this target.

I always comment it so it doesn't download dotnet each time I switch from one project to another.

But perhaps there is good reason for it.

[isaacabraham]

I think the only way it can be useful is if it upgrades the local machine when we upgrade the template to the latest SDK. But for clean machines there's no point is there?.

[MangelMaxime]

Upgrading local machine can be seen as dangerous I think. It will not impact only the template but all the project on the user system.

[isaacabraham]

Agreed. I'm happy to remove that task.

[forki]

I vote to keep it. It's very useful for the rest of the team and it upgrades the stuff for everyone if you touch global.json

[isaacabraham]

I think that's a separate concern though. I've been burned by this - what if you run a project with an old global.json and it overwrites what you already have? Alternatively, you may not want to upgrade - this happens without your evening knowing.

[forki]

not project.json - global.json

and that file is .NET Core best practice

[isaacabraham]

Yeah, sorry - typo. I know they're different :-) Still not sure that's really what we want but open to being educated :-)

[MangelMaxime]

If you think this is the good way I am ok with that :)

It's just take forever (5 to 15minutes) to do the first build. And I suppose my issue is more because I work on a lot of project and it's annoying when each one download his own version of dotnet by erasing the previous ones.

What I am trying to say, his perhaps this not an issue for SAFE-Template because in general people with want to use it for their work and not some OSS project (library, etc.).

[isaacabraham]

First run time is super important. It's already long enough with Paket and Yarn downloading the universe.

[forki]

It won't take forever if you already have the correct version.

[MangelMaxime]

Perhaps, we could simply make it an option in the template ?

[forki]

sure that would work

[isaacabraham]

And turn it off by default. Especially if you have multiple projects this will just end up ping-ponging between versions.

[forki]

It's important to use the correct version. Similar to locking in paket and yarn Isaac Abraham <notifications@github.com> schrieb am Do., 3. Mai 2018, 19:04:

…

And turn it off by default. Especially if you have multiple projects this will just end up ping-ponging between versions. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#79 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADgNPRewb7pzSFR8LdaooUVwRf10laBks5tuziRgaJpZM4TwwtX> .

[theimowski]

If we make it an option, no one is ever going to use it I'm afraid.
Is there any ready-to-use mechanism to use global.json file, but just warn if an older dotnet version is installed instead?

[jarcane]

This actually broke my setup today. The template created a project with .NET Core 2.1.105, when I already had 2.1.300 installed. The build went off fine, eventually, but Ionide couldn't get any of the projects to work, which I then learned was because somehow my local tools had broken as well due to the mismatched version.

Changing global.json to 2.1.300 and reinstalling the SDK fixed it, but it was a nasty surprise.

[forki]

I think a netcore2.1 version will be released soon Am Di., 12. Juni 2018 um 17:20 Uhr schrieb Annaia Berry < notifications@github.com>:

…

This actually broke my setup today. The template created a project with .NET Core 2.1.105, when I already had 2.1.300 installed. The build went off fine, eventually, but Ionide couldn't get any of the projects to work, which I then learned was because somehow my local tools had broken as well due to the mismatched version. Changing global.json to 2.1.300 and reinstalling the SDK fixed it, but it was a nasty surprise. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#79 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADgNN6wjAZRA1zgzTS9VmBJnK9kHzMXks5t79xHgaJpZM4TwwtX> .

[theimowski]

Yes it's still in progress #101

[isaacabraham]

I notice that the FAKE build script also is coupled to a specific version of dotnetcore - so we now have global.json and FAKE pointing to (currently) 2.1.3. I can see people changing one but not other other etc. etc.

[theimowski]

What's your take on moving the required version back to global.json #146 ?

[MangelMaxime]

Better to have one source of truth :) And global.json seems the right place.

[theimowski]

I've decided to remove "Install dotnet" step for now - e4462c9

Let's see what people think of it - if you encounter issues please reopen