-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate paket.lock for all possible template options #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Looks very interesting! Will this generate the lock files in advance or when people create a new project from the template? |
it creates the lock files before packaging up the NuGet, so they are present in the template already |
How many are there currently? |
3 x 2 x 2 x 2 = 24 EDIT: wrong snippet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is to write couple of Fake helper targets for dealing with various paket.lock files in the template.
Because the paket.lock will always have 3 groups:
we can treat each of the group separately to minimize total number of paket.lock permutations.
Workflow in this PR for working with paket.lock
GenPaketLockFiles
Fake target can generate lock files for representative number of template options, split it for each group and save in./Content/{Group}
directoryBuildPaketLockFiles
can take the lock files from corresponding./Content/{Group}
dirs and build all permutations of lock files in./Content
. This target is now dependency ofPack
targetRemovePaketLockFiles
occurs afterPack
target so that the git repo is not littered with generated paket.lock filesGenJsonDefinitions
target can be invoked to print conditions needed to be placed intotemplate.json
manifestUpdatePaketLockFiles
updates all paket lock files (can pass in specific group name(s) as target parameter)Refers to #66