Change default from sass to scss #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leaving an empty last line in style.scss makes the template generation fail with an obscure error.
|
Great, thank you! Let the CI run tests and then I'll make a quick verification tests for some of the fulma templates. |
|
released in 1.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per issue 247 it was decided to change the default style syntax from the old sass to the current scss.
This PR does that by changing the name and content of the old
src/Client/style.sassfile and by changing the corresponding cssEntry property in the generated webpack config file.The sass content was changed to scss by the sass-convert utility built into the official sass gem.