Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put all static content inside the public dir #64

Merged
merged 2 commits into from
Apr 26, 2018
Merged

Put all static content inside the public dir #64

merged 2 commits into from
Apr 26, 2018

Conversation

theprash
Copy link
Member

This simplifies things a little bit in preparation for adding Azure deployment.

@theprash theprash mentioned this pull request Apr 26, 2018
Merged
@isaacabraham isaacabraham requested a review from forki April 26, 2018 17:29
@isaacabraham
Copy link
Member

Can someone test this out to ensure that the docker deploy still works? This is a pre-req for #65 which will allow a pure Azure PAAS deployment.

@isaacabraham
Copy link
Member

@theprash I've tested it out and you can remove the browserRouter scope completely. Kestrel defaults to accepting index.html - see here.

@theimowski theimowski merged commit 9d187a7 into SAFE-Stack:master Apr 26, 2018
@theimowski
Copy link
Member

I've tested Saturn and Suave both with build run and docker images - looks good! Thanks

@theprash theprash deleted the public-dir branch April 27, 2018 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theimowski theimowski Awaiting requested review from theimowski

@forki forki Awaiting requested review from forki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theprash @isaacabraham @theimowski