From 8cd62051860017e59af88f188c4e1ab25d789c96 Mon Sep 17 00:00:00 2001 From: Milan Malfait Date: Thu, 11 Jan 2024 17:13:48 +0000 Subject: [PATCH] Fix ruff rule PLW2901 "redefine loop name" Closes #157 --- pixl_ehr/src/pixl_ehr/_queries.py | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/pixl_ehr/src/pixl_ehr/_queries.py b/pixl_ehr/src/pixl_ehr/_queries.py index 16d93f5a9..5dc29a1b7 100644 --- a/pixl_ehr/src/pixl_ehr/_queries.py +++ b/pixl_ehr/src/pixl_ehr/_queries.py @@ -41,17 +41,17 @@ def _replace_placeholders_and_populate_values(self, context: dict) -> None: continue for key, value in context.items(): - line = line.replace("${{ " + str(key) + " }}", str(value)) # noqa: PLW2901 + new_line = line.replace("${{ " + str(key) + " }}", str(value)) - n = line.count(f":{key}") + n = new_line.count(f":{key}") self.values += n * [value] - line = line.replace(f":{key}", "%s") # noqa: PLW2901 + new_line = new_line.replace(f":{key}", "%s") - if ":" in line.replace("::", "") or "${{" in line: + if ":" in new_line.replace("::", "") or "${{" in new_line: msg = ( "Had an insufficient context to replace " - f"line {i} in {self._filepath}\n" - f"{line}" + f"new_line {i} in {self._filepath}\n" + f"{new_line}" ) raise RuntimeError(msg) - self._lines[i] = line + self._lines[i] = new_line