Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Services using Custom metrics is not usable with all type of bindings #152

Open
dimitarKiryakov opened this issue Jan 4, 2023 · 1 comment

Comments

@dimitarKiryakov
Copy link

dimitarKiryakov commented Jan 4, 2023

Hello Colleagues,
Currently, the feature of https://github.com/SAP/cf-java-logging-support#custom-metrics is very usable.
Unfortunately due to this condition here:
https://github.com/SAP/cf-java-logging-support/blob/master/cf-java-monitoring-custom-metrics-clients/cf-custom-metrics-clients-spring-boot/src/main/java/com/sap/cloud/cf/monitoring/spring/configuration/CustomMetricsCondition.java

service that does not use application-logging could not benefit from it. Please remove this condition in order for custom drainers for example([redacted]) to benefit from it in CF.

There is a workaround to predefine the autoconfigure annotation but it is a very ugly one.

@KarstenSchnitter
Copy link
Contributor

Hi,

thanks for reaching out. The support for custom metrics is highly specific to the SAP BTP Application Logging Service, where there is matching parsing in place. It is not intended to be used in other context, where superior solutions exist. These could e.g. be a metrics registry for Spring Boot, a Prometheus endpoint or additional instrumentation with OpenTelemetry. The custom metrics modules of cf-java-logging-support should not be used for these use-cases.

Best Regards,
Karsten

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants