From 4c6107635b7a5089e14b899e4f9dc81a530e812d Mon Sep 17 00:00:00 2001 From: Harald Fuchs Date: Thu, 24 Aug 2023 12:52:30 +0200 Subject: [PATCH 1/4] Add `memory` and `disk_quota` clauses to `manifest.yml` --- sample/manifest.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sample/manifest.yml b/sample/manifest.yml index 974e70c..d7f8f1a 100644 --- a/sample/manifest.yml +++ b/sample/manifest.yml @@ -5,6 +5,8 @@ applications: # - name: logging-sample-app instances: 1 + memory: 592M + disk_quota: 140M path: target/logging-sample-app-3.7.0.war env: RANDOM_SLEEP: true From 8518c52ff2edd9707edb373ff8e239cb2e7abdfb Mon Sep 17 00:00:00 2001 From: Harald Fuchs Date: Wed, 30 Aug 2023 11:18:16 +0200 Subject: [PATCH 2/4] Use the SAP Java buildpack --- sample/manifest.yml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/sample/manifest.yml b/sample/manifest.yml index d7f8f1a..f46a9e2 100644 --- a/sample/manifest.yml +++ b/sample/manifest.yml @@ -5,8 +5,9 @@ applications: # - name: logging-sample-app instances: 1 - memory: 592M - disk_quota: 140M + buildpack: sap_java_buildpack + memory: 256M + disk_quota: 256M path: target/logging-sample-app-3.7.0.war env: RANDOM_SLEEP: true @@ -14,3 +15,7 @@ applications: LOG_SENSITIVE_CONNECTION_DATA: false LOG_REMOTE_USER: false LOG_REFERER: false + # Some defaults in the SAP Java buildpack much higher than what this app needs. + # The values below have been devised empirically + JAVA_OPTS: '-XX:ReservedCodeCacheSize=40M -XX:MaxMetaspaceSize=28M -Xss256K' + # Default: '-XX:ReservedCodeCacheSize=240M -XX:MaxMetaspaceSize=141152K -Xss1M' From c7614b754b0f784a363f448847c7c1ae8565d917 Mon Sep 17 00:00:00 2001 From: haraldfuchs Date: Thu, 31 Aug 2023 10:14:13 +0200 Subject: [PATCH 3/4] Removed the `disk_quota` clause --- sample/manifest.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/sample/manifest.yml b/sample/manifest.yml index f46a9e2..9b6439d 100644 --- a/sample/manifest.yml +++ b/sample/manifest.yml @@ -7,7 +7,6 @@ applications: instances: 1 buildpack: sap_java_buildpack memory: 256M - disk_quota: 256M path: target/logging-sample-app-3.7.0.war env: RANDOM_SLEEP: true From ec8b342fcd7c21958d70c52bc7d75b496336726c Mon Sep 17 00:00:00 2001 From: Karsten Schnitter Date: Thu, 31 Aug 2023 13:49:42 +0200 Subject: [PATCH 4/4] Set comment above implementation --- sample/manifest.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sample/manifest.yml b/sample/manifest.yml index 9b6439d..1134460 100644 --- a/sample/manifest.yml +++ b/sample/manifest.yml @@ -16,5 +16,5 @@ applications: LOG_REFERER: false # Some defaults in the SAP Java buildpack much higher than what this app needs. # The values below have been devised empirically - JAVA_OPTS: '-XX:ReservedCodeCacheSize=40M -XX:MaxMetaspaceSize=28M -Xss256K' # Default: '-XX:ReservedCodeCacheSize=240M -XX:MaxMetaspaceSize=141152K -Xss1M' + JAVA_OPTS: '-XX:ReservedCodeCacheSize=40M -XX:MaxMetaspaceSize=28M -Xss256K'