Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 [JIRA: 0] add isSameHeight in Carousel and update some cards based on reviews #783

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

shengxu7
Copy link
Member

@shengxu7 shengxu7 commented Aug 26, 2024

Added same height Carousel for card
Simulator Screenshot - iPad Pro 13-inch (M4) - 2024-08-26 at 14 45 28

isSameHeight is false and alignment is top:
Simulator Screenshot - iPad Pro 13-inch (M4) - 2024-08-26 at 14 49 08

@shengxu7 shengxu7 requested a review from a team as a code owner August 26, 2024 21:40
@shengxu7 shengxu7 requested review from billzhou0223 and dyongxu and removed request for a team August 26, 2024 21:40
@shengxu7 shengxu7 changed the title feat: add isSameHeight in Carousel and update some cards based on reviews feat: 🎸 [jira: 0] add isSameHeight in Carousel and update some cards based on reviews Aug 26, 2024
@shengxu7 shengxu7 changed the title feat: 🎸 [jira: 0] add isSameHeight in Carousel and update some cards based on reviews feat: 🎸 [JIRA: 0] add isSameHeight in Carousel and update some cards based on reviews Aug 27, 2024
@shengxu7 shengxu7 merged commit 2a533e0 into SAP:main Aug 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants