-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 🎸 sort & filter enhancement part 2 #820
feat: 🎸 sort & filter enhancement part 2 #820
Conversation
add listpick
The attached screenshot seems a selection dialog used somewhere. The missing picture is how the dialog is shown? In other words, how the list picker looks like when it's associated with filter feedback bar or when it's mixed with other type of values in full configuration?
And, can you provide information/link on requirements? |
Click feedBackbarItem shows the dialog.
|
Thanks for providing info and answers. Some further comments:
You might want to check with designer. I wish I could figure out who is the designer and talk to him/her on your behalf. |
Sources/FioriSwiftUICore/Views/SortFilter/FilterFeedbackBarItem+View.swift
Outdated
Show resolved
Hide resolved
public var displayMode: DisplayMode = .automatic | ||
|
||
/// Available OptionListPicker modes. Use this enum to define picker mode to present. | ||
public enum DisplayMode { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nesting Violation: Types should be nested at most 1 level deep (nesting)
public var displayMode: DisplayMode = .automatic | ||
|
||
/// Available OptionListPicker modes. Use this enum to define picker mode to present. | ||
public enum DisplayMode { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nesting Violation: Types should be nested at most 1 level deep (nesting)
Checked some details with the designer Escutia, Max
|
@CharlesXu0488 @billzhou0223 Please continue to review. Thanks. |
Thanks for iPad screenshots and info from designer. Is Max OK with "full" sheet instead of "flexible" sheet of the second screenshot? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please work with Bill on his change request. For the rest, your answers to my questions and concerns look good.
add listpick
when listPickerMode is set to .automatic
items display mode is according to options count:
[1-4] menu
[5-8] filter form cell
(8- list
![Simulator Screenshot - iPhone 16 Pro Max - 2024-10-16 at 16 00 08](https://github.com/user-attachments/assets/5ed68d59-2cd5-4b27-8e0c-459d81e872ee)