Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 [JIRA:HCPSDKFIORIUIKIT-2790]update chart1 color #866

Merged
merged 3 commits into from
Nov 6, 2024
Merged

fix: 🐛 [JIRA:HCPSDKFIORIUIKIT-2790]update chart1 color #866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bdf5ade
fix: 🐛 [JIRA:HCPSDKFIORIUIKIT-2790]update chart1 color
KevinZK Nov 6, 2024
9c4069d
fix: 🐛 [JIRA:HCPSDKFIORIUIKIT-2790]fix test
KevinZK Nov 6, 2024
9de41f2
Merge branch 'main' into JIRA-0_updateChartColor
KevinZK Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/FioriThemeManager/Colors/ColorStyle.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1079,8 +1079,8 @@ public enum ColorStyle: String, CaseIterable {
// MARK: - Chart Colors (13 Styles)

/// Chart 1
/// (dark variant) ![](https://dummyimage.com/48x18/3278BE.png&text=+) Hex value: 3278BEFF
/// (light variant) ![](https://dummyimage.com/48x18/3278BE.png&text=+) Hex value: 3278BEFF
/// (dark variant) ![](https://dummyimage.com/48x18/168EFF.png&text=+) Hex value: 168EFFFF
/// (light variant) ![](https://dummyimage.com/48x18/168EFF.png&text=+) Hex value: 168EFFFF
@available(watchOS, unavailable)
case chart1

Expand Down
2 changes: 1 addition & 1 deletion Sources/FioriThemeManager/Palettes/PaletteV8.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ struct PaletteV8: PaletteProvider {
.chrome: HexColor(lightColor: "000000BF", darkColor: "FFFFFFD9", elevatedLightColor: "171D23BF", contrastLightColor: "000000E6", contrastDarkColor: "FFFFFFE6", elevatedContrastLightColor: "192024E6"),
.chromeSecondary: HexColor(lightColor: "161C21BF", darkColor: "FFFFFFD9", elevatedLightColor: "242D37BF", contrastLightColor: "1D252AE6", contrastDarkColor: "FFFFFFE6", elevatedContrastLightColor: "212B30E6"),
/// Chart Colors
.chart1: HexColor(lightColor: "3278BEFF", darkColor: "3278BEFF", contrastLightColor: "8BABCBFF", contrastDarkColor: "446E97FF"),
.chart1: HexColor(lightColor: "168EFFFF", darkColor: "168EFFFF", contrastLightColor: "8BABCBFF", contrastDarkColor: "446E97FF"),
.chart2: HexColor(lightColor: "F2A634FF", darkColor: "C87B00FF", contrastLightColor: "ED8859FF", contrastDarkColor: "D74114FF"),
.chart3: HexColor(lightColor: "B4CE35FF", darkColor: "75980BFF", contrastLightColor: "9FB822FF", contrastDarkColor: "2D6F51FF"),
.chart4: HexColor(lightColor: "FA4F96FF", darkColor: "DF1278FF", contrastLightColor: "FE74AEFF", contrastDarkColor: "DF1278FF"),
Expand Down
2 changes: 1 addition & 1 deletion Tests/FioriSwiftUITests/FioriThemeManager/ThemeManagerTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ class ThemeManagerTests: XCTestCase {
let raspberry10 = tm.hexColor(for: .raspberry10)
XCTAssertEqual(raspberry10, HexColor(lightColor: "FFDCE8FF", darkColor: "71014BFF", contrastLightColor: "FFF0F5FF", contrastDarkColor: "320021FF"))
let chart1 = tm.hexColor(for: .chart1)
XCTAssertEqual(chart1, HexColor(lightColor: "3278BEFF", darkColor: "3278BEFF", contrastLightColor: "8BABCBFF", contrastDarkColor: "446E97FF"))
XCTAssertEqual(chart1, HexColor(lightColor: "168EFFFF", darkColor: "168EFFFF", contrastLightColor: "8BABCBFF", contrastDarkColor: "446E97FF"))
let chart2 = tm.hexColor(for: .chart2)
XCTAssertEqual(chart2, HexColor(lightColor: "F2A634FF", darkColor: "C87B00FF", contrastLightColor: "ED8859FF", contrastDarkColor: "D74114FF"))
let chart3 = tm.hexColor(for: .chart3)
Expand Down
Loading