feat: 🎸 [JIRA:HCPSDKFIORIUIKIT-2806] Processing Indicator #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
angiexyang
commented
Nov 26, 2024
angiexyang
commented
angiexyang
requested review from
billzhou0223
and removed request for
a team
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| /// ProcessingIndicator(optionalTitle: "Processing") | ||
| /// ``` | ||
| // sourcery: CompositeComponent | ||
| protocol _ProcessingIndicatorComponent: _OptionalTitleComponent {} |
There was a problem hiding this comment.
File Length Violation: File should contain 700 lines or less: currently contains 728 (file_length)
dyongxu
reviewed
Nov 27, 2024
| .padding() | ||
| .fullScreenCover(isPresented: self.$showModalIndicator, content: { | ||
| VStack { | ||
| ProcessingIndicator(optionalTitle: "Loading") |
There was a problem hiding this comment.
Use the same as line 35, so title can be from tester as well in this case.
ProcessingIndicator(optionalTitle: AttributedString(self.labelText))
dyongxu
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.