[FIX] generateLibraryManifest: i18n/css handling

SAP · Jul 17, 2018 · 4e52a96 · 4e52a96
1 parent 4826821
commit 4e52a96
Show file tree

Hide file tree

Showing 3 changed files with 489 additions and 4 deletions.
diff --git a/lib/processors/manifestCreator.js b/lib/processors/manifestCreator.js
@@ -399,9 +399,9 @@ async function createManifest(libraryResource, libBundle, descriptorVersion, _in
  let i18nElement = findChild(libraryAppData, "i18n");
  if ( i18nElement ) {
  let i18n = i18nElement._;
- if ( "false".equals(i18n) ) {
+ if ( i18n === "false" ) {
  return false;
- } else if ( "true".equals(i18n) ) {
+ } else if ( i18n === "true" ) {
  return "messagebundle.properties";
  } else {
  return i18n;
@@ -424,7 +424,7 @@ async function createManifest(libraryResource, libBundle, descriptorVersion, _in
  let cssElement = findChild(libraryAppData, "css");
  if ( cssElement != null ) {
  let css = cssElement._;
- if ( "false".equals(css) ) {
+ if ( css === "false" ) {
  log.verbose(" sap.ui5/library/css property taken from .library appData: '%s'", false);
  return false;
  }

diff --git a/lib/tasks/generateLibraryManifest.js b/lib/tasks/generateLibraryManifest.js
@@ -26,7 +26,8 @@ module.exports = function({workspace, dependencies, options}) {
  // *.json files are needed to avoid overwriting them
  // *.js files are needed to identify nested components
  // *.less, *.css, *.theming and *.theme files are needed to identify supported themes
- return combo.byGlob("/**/*.{js,json,library,less,css,theming,theme}").then((resources) => {
+ // *.properties to identify existence of i18n bundles (e.g. messagebundle.properties)
+ return combo.byGlob("/**/*.{js,json,library,less,css,theming,theme,properties}").then((resources) => {
  // Find all libraries and create a manifest.json file
  return workspace.byGlob("/resources/**/.library").then((libraryIndicatorResources) => {
  if (libraryIndicatorResources.length < 1) {