Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Builder: Add handling for custom task configurations #106

Merged
merged 1 commit into from
Nov 16, 2018

Conversation

RandomByte
Copy link
Member

As per RFC0004: SAP/ui5-tooling#54

RandomByte added a commit to RandomByte/openui5-sample-app that referenced this pull request Nov 16, 2018
@coveralls
Copy link

coveralls commented Nov 16, 2018

Pull Request Test Coverage Report for Build 455

  • 23 of 61 (37.7%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.7%) to 63.119%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/types/module/ModuleBuilder.js 0 1 0.0%
lib/tasks/taskRepository.js 3 10 30.0%
lib/types/AbstractBuilder.js 18 48 37.5%
Totals Coverage Status
Change from base Build 452: -2.7%
Covered Lines: 658
Relevant Lines: 953

💛 - Coveralls

RandomByte added a commit to SAP/ui5-project that referenced this pull request Nov 16, 2018
@RandomByte RandomByte changed the title [FEATURE] Task Extensibility: Add handling for custom task project configuration [FEATURE] Builder: Add handling for custom task configurations Nov 16, 2018
RandomByte added a commit to RandomByte/openui5-sample-app that referenced this pull request Nov 16, 2018
RandomByte added a commit to SAP/ui5-project that referenced this pull request Nov 16, 2018
@RandomByte RandomByte merged commit 9b4ae00 into master Nov 16, 2018
@RandomByte RandomByte deleted the ext-tasks branch November 16, 2018 13:43
RandomByte added a commit to SAP/ui5-project that referenced this pull request Nov 17, 2018
RandomByte added a commit to SAP/ui5-project that referenced this pull request Nov 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants