Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] reduce build time at the price of a slightly increased code size #37

Merged
merged 1 commit into from
Jun 25, 2018

Conversation

codeworrior
Copy link
Member

Documentation of uglify-es suggests that compress:false already achieves
a very good code size reduction at a much higher speed, see
https://github.com/mishoo/UglifyJS2/tree/harmony#uglify-fast-minify-mode

Documentation of uglify-es suggests that compress:false already achieves
a very good code size reduction at a much higher speed, see
https://github.com/mishoo/UglifyJS2/tree/harmony#uglify-fast-minify-mode
@RandomByte
Copy link
Member

So I was curious and tried this with the latest openui5-sample-app:

ui5-builder master

❯ time ui5 build --all
[...]
info builder:builder Build succeeded in 1.37 min
ui5 build --all  110.83s user 7.46s system 138% cpu 1:25.25 total

❯ du -s dist
141240 KBytes

ui5-builder improve-performance-of-uglify-task

❯ time ui5 build --all
[...]
info builder:builder Build succeeded in 41 s
ui5 build --all  58.47s user 6.13s system 145% cpu 44.514 total

❯ du -s dist
141752 KBytes

Summary

Build time: 1:25.25 min ↘️0:44.514 min (-41sec / -48%)
Size: 141240 KB ↗️141752 KB (+512 KB / 0.36%)

Fair enough I guess

@codeworrior codeworrior merged commit 1fb8d00 into master Jun 25, 2018
@codeworrior codeworrior deleted the improve-performance-of-uglify-task branch June 25, 2018 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants