[FEATURE] AbstractAdapter: Add excludes option #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
RandomByte
force-pushed
the
static-excludes
branch
from
3cb36d0
to
f28145f
Compare
Unpin dir-glob
- globby: 'nodir' option renamed to 'onlyFiles'
- globby: Now transforms empty GLOB strings into globstar (matching
everything instead of nothing)
- mitigated by not globbing with empty strings anymore
- globby/micromatch: Including excluded paths is now possible
- before this was inconsistent
- FileSystem._runGlob now throws errors for glob errors (instead of
catching and logging them)
RandomByte
force-pushed
the
static-excludes
branch
from
8c97b14
to
be884d6
Compare
This caused loops in cyclic npm dependencies. The 'follow' option of node-glob also defaults to false.
RandomByte
force-pushed
the
static-excludes
branch
from
3d552e2
to
c81e2c5
Compare
The useNamespace flag was not sufficient in cases where the namespace should only be added for projects that do not already represent it in their directory structure. With SAP/ui5-builder#255 libraries will have a namespace property even though their directory structure already represents the namespace.
RandomByte
added a commit
to SAP/ui5-server
that referenced
this pull request
May 27, 2019
RandomByte
added a commit
to SAP/ui5-server
that referenced
this pull request
May 27, 2019
…or GLOB errors See SAP/ui5-fs#140 The tmp directory might not be present during the execution of this test. However, its usage didn't really add any value to the test anyways.
RandomByte
added a commit
to SAP/ui5-server
that referenced
this pull request
May 28, 2019
…ow throws for GLOB errors See SAP/ui5-fs#140 The tmp directory might not be present during the execution of this test. However, its usage didn't really add any value to the test anyways.
RandomByte
added a commit
to SAP/ui5-server
that referenced
this pull request
May 28, 2019
…ow throws for GLOB errors See SAP/ui5-fs#140 The tmp directory might not be present during the execution of this test. However, its usage didn't really add any value to the test anyways.
RandomByte
force-pushed
the
static-excludes
branch
from
8cfdc23
to
2447359
Compare
matz3
requested changes
May 29, 2019
- Rename isExcludedPath to isPathExcluded - Also resolve with null instead of undefined if a resource has been excluded - Rename GLOB to glob as already decided earlier
RandomByte
force-pushed
the
static-excludes
branch
from
98db583
to
5dce36b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.