Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] FileSystem Adapter: Use native fs.copy / Skip writing when resource is unchanged #370

Merged
merged 6 commits into from
Apr 21, 2022

Conversation

matz3
Copy link
Member

@matz3 matz3 commented Apr 14, 2022

No description provided.

@matz3 matz3 marked this pull request as ready for review April 19, 2022 14:12
@coveralls
Copy link

coveralls commented Apr 19, 2022

Coverage Status

Coverage increased (+0.1%) to 87.5% when pulling dbbe89f on next-native-copy into 354f694 on next.

@matz3 matz3 changed the title [WIP][PERF] FileSystem Adapter: Use native fs.copy when possible [FIX] FileSystem Adapter: Use native fs.copy / Skip writing when resource is unchanged Apr 19, 2022
* Always resolve fsBasePath to absolute path for later comparison
* Always transform stream into buffer if write path equals source path
@matz3
Copy link
Member Author

matz3 commented Apr 20, 2022

LGTM, but I'm going to test this once again with the component bundle script.

RandomByte
RandomByte previously approved these changes Apr 20, 2022
@matz3
Copy link
Member Author

matz3 commented Apr 20, 2022

Also, we should add some new tests. I'll be looking into that.

@matz3 matz3 added the bug Something isn't working label Apr 21, 2022
@matz3 matz3 merged commit 9ac6a39 into next Apr 21, 2022
@matz3 matz3 deleted the next-native-copy branch April 21, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants