Skip to content

Commit

Permalink
fix: Eslint findings
Browse files Browse the repository at this point in the history
  • Loading branch information
d3xter666 authored and github-actions[bot] committed Sep 10, 2024
1 parent f15710c commit f72109c
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 7 deletions.
2 changes: 1 addition & 1 deletion src/cli/base.ts
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ export default function base(cli: Argv) {
} else {
process.stderr.write("\n");
process.stderr.write(chalk.dim(`For details, execute the same command again with an` +
` additional '--verbose' parameter`) + "\n");
` additional '--verbose' parameter`) + "\n");
}
}
} else {
Expand Down
2 changes: 1 addition & 1 deletion src/formatter/text.ts
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ export class Text {
if (!showDetails && (totalErrorCount + totalWarningCount + totalFatalErrorCount) > 0) {
this.#writeln("");
this.#writeln(chalk.dim.bold("Note: ") +
chalk.dim(`Use "ui5lint --details" to show more information about the findings`));
chalk.dim(`Use "ui5lint --details" to show more information about the findings`));
}

return this.#buffer;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ function collectImports(
let moduleSpecifier: ts.StringLiteral;
if (!ts.isStringLiteralLike(dep)) {
log.verbose(`Skipping non-string dependency entry of type ${ts.SyntaxKind[dep.kind]} at ` +
toPosStr(dep));
toPosStr(dep));
return;
}
if (ts.isNoSubstitutionTemplateLiteral(dep)) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export function transformAsyncRequireCall(
let moduleSpecifier: ts.StringLiteral;
if (!ts.isStringLiteralLike(dep)) {
log.verbose(`Skipping non-string dependency entry of type ${ts.SyntaxKind[dep.kind]} at ` +
toPosStr(dep));
toPosStr(dep));
return;
}
if (ts.isNoSubstitutionTemplateLiteral(dep)) {
Expand Down
3 changes: 2 additions & 1 deletion src/linter/ui5Types/asyncComponentFlags.ts
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,8 @@ function reportResults({
severity: LintMessageSeverity.Warning,
ruleId: "ui5-linter-async-component-flags",
message: `Component implements the sap.ui.core.IAsyncContentCreation interface. ` +
`The redundant "async" flag at "${pointerKey}" should be removed from the component manifest`,
`The redundant "async" flag at "${pointerKey}" should be removed ` + `
from the component manifest`,
messageDetails: `{@link sap.ui.core.IAsyncContentCreation sap.ui.core.IAsyncContentCreation}`,
...posInfo,
});
Expand Down
4 changes: 2 additions & 2 deletions src/linter/xmlTemplate/Parser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ export default class Parser {

if (!aggregationName) {
log.verbose(`Failed to determine default aggregation for control ${owner.name} used in ` +
`resource ${this.#resourceName}. Falling back to 'dependents'`);
`resource ${this.#resourceName}. Falling back to 'dependents'`);
// In case the default aggregation is unknown (e.g. in case of custom controls),
// fallback to use the generic "dependents" aggregation
// This is not correct at runtime, but it's the best we can do for linting purposes
Expand Down Expand Up @@ -460,7 +460,7 @@ export default class Parser {
this.#generator.writeControl(customData);
} else {
log.verbose(`Ignoring unknown namespaced attribute ${attr.localNamespace}:${attr.name} ` +
`for ${moduleName} in resource ${this.#resourceName}`);
`for ${moduleName} in resource ${this.#resourceName}`);
}
} else {
controlProperties.add(attr);
Expand Down

0 comments on commit f72109c

Please sign in to comment.