[FIX] projectPreprocessor: Do not remove already removed dependencies #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lead to the wrong dependency being removed in some cases. Credits to @nlunets for reporting this issue.
RandomByte
force-pushed
the
project-preproc-no-remove-wrong-dependency
branch
from
d10800c
to
94422f3
Compare
matz3
reviewed
Jun 24, 2019
Co-Authored-By: Matthias Oßwald <1410947+matz3@users.noreply.github.com>
|
Note: Squash it |
Thodd
approved these changes
Jun 25, 2019
| @@ -163,7 +163,9 @@ class ProjectPreprocessor { | |||
| if (processedProject) { | |||
| if (processedProject.ignored) { | |||
| log.verbose(`Dependency of project ${parent.id}, "${project.id}" is flagged as ignored.`); | |||
| parent.dependencies.splice(parent.dependencies.indexOf(project), 1); | |||
There was a problem hiding this comment.
Oh, splicing index -1 is a nice bug :D
matz3
approved these changes
Jun 25, 2019
nlunets
approved these changes
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lead to the wrong dependency being removed in some cases.
Credits to @nlunets