[FEATURE] Add ui5Framework translator and resolvers #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomByte
reviewed
Mar 5, 2020
matz3
force-pushed
the
ui5Framework-translator
branch
from
ed0032c
to
774651a
Compare
RandomByte
reviewed
Mar 5, 2020
RandomByte
reviewed
Mar 5, 2020
RandomByte
reviewed
Mar 6, 2020
matz3
commented
Mar 6, 2020
RandomByte
reviewed
Mar 9, 2020
matz3
force-pushed
the
ui5Framework-translator
branch
2 times, most recently
from
b3e8875
to
c151c9d
Compare
toJSON is actually required
Also log some more relevant npm config values
An error was detected while testing with a path that is not explicitly
absolute or relative, which results into requiring from node_modules.
e.g. require("path/to/metadata.json") would try to find
"to/metadata.json" within the "path" package.
This might be solve by using path.resolve on the path passed to require.
But this still leaves a problem open, which is a secuirity risk of
requiring a file that is dynamically downloaded. If it doesn't contain
JSON but JavaScript it would be executed directly.
Therefore, using fs.readFile + JSON.parse is a much better approach.
matz3
force-pushed
the
ui5Framework-translator
branch
from
6fad739
to
74bd5ba
Compare
RandomByte
approved these changes
Mar 10, 2020
matz3
changed the title
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution! 🙌
To get it merged faster, kindly review the checklist below:
Pull Request Checklist